Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds documentation to Android deferred proration #1387

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Adds documentation to Android deferred proration #1387

merged 1 commit into from
Jun 24, 2021

Conversation

andresesfm
Copy link
Contributor

@andresesfm andresesfm commented Jun 22, 2021 •
edited
Loading

Credit goes to @Paduado and @hyochan
See discussion here: #888
It adds documentation so now we can close:
#555

This was referenced Jun 22, 2021
Closed
Closed
@hyochan hyochan added the 📖 documentation Improvements or additions to documentation label Jun 23, 2021
hyochan
hyochan reviewed Jun 23, 2021
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you kindly check above comments?

android/src/play/java/com/dooboolab/RNIap/RNIapModule.java Show resolved Hide resolved
android/src/play/java/com/dooboolab/RNIap/RNIapModule.java Show resolved Hide resolved
@hyochan hyochan added 🍗 enhancement New feature or request 🤖 android Related to android labels Jun 23, 2021
hyochan
hyochan approved these changes Jun 24, 2021
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution as usual :)

@hyochan hyochan merged commit 26a2e0b into hyochan:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🤖 android Related to android 📖 documentation Improvements or additions to documentation 🍗 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresesfm @hyochan