Code

Fix padding calculation, closes #45#46

Code

Merged

hypebeast merged 29 commits intohypebeast:masterhypebeast/go-osc:masterfrom peternewman:patch-1peternewman/go-osc:patch-1Copy head branch name to clipboardMar 23, 2021

+80-34

Commits

Commits on Nov 25, 2020

• Fix padding calculation, hopefully fixes hypebeast#45

  Show description for d37d833
  peternewman

  authored
  d37d833

  Copy full SHA for d37d833

Commits on Mar 19, 2021

• Add some more byte padding tests (and fix up the broken ones)

  peternewman

  authored
  73358d0

  Copy full SHA for 73358d0

• Fix the incorrect padding on the example packet

  peternewman

  authored
  6b33958

  Copy full SHA for 6b33958

• Guess at how to fix the out of range error

  Show description for c642f32
  peternewman

  authored
  c642f32

  Copy full SHA for c642f32

• Try the other way to fix the calculation

  peternewman

  authored
  6ff26a0

  Copy full SHA for 6ff26a0

• Fix a lint issue

  peternewman

  authored
  a6d96e2

  Copy full SHA for a6d96e2

• Actually use the maths I tested which works in Go

  peternewman

  authored
  4921c45

  Copy full SHA for 4921c45

• Further correction to the formula

  peternewman

  authored
  ee0d744

  Copy full SHA for ee0d744

• Try not removing stuff twice again

  peternewman

  authored
  54b9f88

  Copy full SHA for 54b9f88

Commits on Mar 22, 2021

• Add some more tests

  peternewman

  authored
  3a93378

  Copy full SHA for 3a93378

• Correct the padding bytes needed calculation to actually work

  peternewman

  authored
  699e7b6

  Copy full SHA for 699e7b6

• Add some more debug

  peternewman

  authored
  31e0e07

  Copy full SHA for 31e0e07

• Don't remove the string delimiter

  peternewman

  authored
  0199891

  Copy full SHA for 0199891

• Add more debugging

  peternewman

  authored
  5d752b6

  Copy full SHA for 5d752b6

• We do actually need to remove the string delimiter

  peternewman

  authored
  8fea809

  Copy full SHA for 8fea809

• Address @chabad360 comments

  peternewman

  authored
  4d26d19

  Copy full SHA for 4d26d19

• Add @chabad360 's extra tests, but fix one I think is incorrect

  peternewman

  authored
  7075a58

  Copy full SHA for 7075a58

• Add support for expected errors in TestReadPaddedString

  peternewman

  authored
  952f77b

  Copy full SHA for 952f77b

• Improve TestWritePaddedString with more test cases

  peternewman

  authored
  1b4ed37

  Copy full SHA for 1b4ed37

• Fix the test code

  peternewman

  authored
  d9159af

  Copy full SHA for d9159af

• Fix the type of an argument to equal

  peternewman

  authored
  c5b9767

  Copy full SHA for c5b9767

• Fix a test and add another one

  peternewman

  authored
  ba7f2d6

  Copy full SHA for ba7f2d6

• Add the null byte to the end of strings

  peternewman

  authored
  f2ddec4

  Copy full SHA for f2ddec4

• Fix the check for pre-existing nulls

  peternewman

  authored
  11cef41

  Copy full SHA for 11cef41

• Add even more tests around nulls

  peternewman

  authored
  495f85c

  Copy full SHA for 495f85c

• Use full escaped strings for more helpful troubleshooting

  peternewman

  authored
  7893ee4

  Copy full SHA for 7893ee4

• We want to know if they're NOT equal!

  peternewman

  authored
  62ff709

  Copy full SHA for 62ff709

• Ensure we correctly handle multiple nulls in the incoming string

  peternewman

  authored
  7a0dc97

  Copy full SHA for 7a0dc97

• Fix the lint issue

  peternewman

  authored
  41e1b81

  Copy full SHA for 41e1b81