Merge pull request #10 from hyper63/twilson63/bug-bulk-command-should-8

fix: return ok:true for each item in bulk results #8

Author: twilson63

.github/workflows/test.yml

@@ -2,15 +2,15 @@ name: Test
 
 on:
   push:
-    branches: '**'
-    tags-ignore: '*'
+    branches: "**"
+    tags-ignore: "*"
 
 jobs:
   build:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        deno-version: [1.11.x]
+        deno-version: [1.x]
     steps:
       - uses: actions/checkout@v2
       - name: Use Deno ${{ matrix.deno-version }}

README.md

@@ -16,6 +16,7 @@
 - [Features](#features)
 - [Methods](#methods)
 - [Contributing](#contributing)
+- [Testing](#testing)
 - [License](#license)
 
 ## Getting Started
@@ -65,6 +66,29 @@ This adapter fully implements the Search port and can be used as the
 
 See the full port [here](https://nest.land/package/hyper-port-search)
 
+## Testing
+
+- Spin up docker image locally
+
+```sh
+docker run \
+-p 9200:9200 -p 9600:9600 \
+-e "discovery.type=single-node" \
+-v /workspace/hyper-adapter-elasticsearch/scripts/opensearch.yml:/usr/share/opensearch/config/opensearch.yml \
+opensearchproject/opensearch:1.2.3
+```
+
+- Run hyper
+
+```sh
+./scripts/hyper.sh
+```
+
+- Run hyper-test
+
+```
+```
+
 ## Contributing
 
 Contributions are welcome! See the hyper

adapter.js

@@ -268,7 +268,11 @@ export default function ({ config, asyncFetch, headers, handleResponse }) {
       )
       .bichain(
         handleRejectedResponse,
-        (res) => Async.Resolved({ ok: true, results: res.items }),
+        (res) =>
+          Async.Resolved({
+            ok: true,
+            results: map((o) => ({ ok: true, id: o.index._id }), res.items),
+          }),
       )
       .toPromise();
   }
@@ -310,10 +314,10 @@ export default function ({ config, asyncFetch, headers, handleResponse }) {
         // Success
         (res) =>
           Async.Resolved(
-            ({
+            {
               ok: true,
               matches: pluck("_source", res.hits.hits),
-            }),
+            },
           ),
       )
       .toPromise();

adapter_test.js

@@ -175,8 +175,8 @@ Deno.test("bulk", async () => {
   // bulk operation
   stubResponse(200, {
     items: [
-      DOC1,
-      DOC2,
+      { index: { _id: DOC1.id, ...DOC1 } },
+      { index: { _id: DOC2.id, ...DOC2 } },
     ],
   });
 

scripts/hyper.js

@@ -0,0 +1,20 @@
+import hyper from "https://x.nest.land/hyper@2.0.0/mod.js";
+import app from "https://x.nest.land/hyper-app-opine@1.2.7/mod.js";
+
+import search from "../mod.js";
+
+await hyper({
+  app,
+  adapters: [
+    {
+      port: "search",
+      plugins: [
+        search({
+          url: "http://localhost:9200",
+          username: "admin",
+          password: "admin",
+        }),
+      ],
+    },
+  ],
+});

scripts/hyper.sh

@@ -0,0 +1 @@
+deno run -A --unstable --no-check ./scripts/hyper.js

scripts/opensearch.yml

@@ -0,0 +1,18 @@
+cluster.name: docker-cluster
+
+# Bind to all interfaces because we don't know what IP address Docker will assign to us.
+network.host: 0.0.0.0
+
+# # minimum_master_nodes need to be explicitly set when bound on a public IP
+# # set to 1 to allow single node clusters
+# discovery.zen.minimum_master_nodes: 1
+
+# Setting network.host to a non-loopback address enables the annoying bootstrap checks. "Single-node" mode disables them again.
+#discovery.type: single-node
+
+######## Start OpenSearch Security Demo Configuration ########
+# WARNING: revise all the lines below before you go into production
+plugins.security.disabled: true
+
+node.max_local_storage_nodes: 3
+######## End OpenSearch Security Demo Configuration ########

scripts/test.sh

@@ -1,5 +1,3 @@
 #!/usr/bin/env bash
 
-deno lint
-deno fmt --check
-deno test
+deno lint && deno fmt --check && deno test