fix: return ok:true for each item in bulk results #8 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
TillaTheHun0
left a comment
TillaTheHun0
left a comment
There was a problem hiding this comment.
Had a question on the value of id in the response.
Contributor
Author
|
Good thought I will double check
Maybe I just happen to send the same during my test
…Sent from my iPhone
On Jan 18, 2022, at 5:54 PM, Tyler Hall ***@***.***> wrote:
@TillaTheHun0 commented on this pull request.
In adapter.js:
> @@ -268,7 +268,11 @@ export default function ({ config, asyncFetch, headers, handleResponse }) {
)
.bichain(
handleRejectedResponse,
- (res) => Async.Resolved({ ok: true, results: res.items }),
+ (res) =>
+ Async.Resolved({
+ ok: true,
+ results: map((o) => ({ ok: true, id: o.index._id }), res.items),
My thoughts is because name is consumer provided, and what the consumer will use to reference and consume the index on subsequent calls.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.