Fix returning null from ExtendScript with evalTS #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction Steps:
Create an ExtendScript function which returns
null
and call it usingevalTS
Expected:
evalTS
should resolve its promise with the value ofnull
Actual:
evalTS
rejects its promise with the value ofnull
, because the line... attempts to evaluate the
.name
property ofnull
, which raises aTypeError
. This error is caught by the surroundingtry/catch
, which then rejects the promise with thenull
value.Fix: Use safe navigation operator to access
parsed.name
so that aTypeError
is not raised