chore: bump otel deps + remove hdx node logger #102
Conversation
🦋 Changeset detectedLatest commit: 08c91f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wrn14897
force-pushed
the
warren/bump-otel-deps-n-remove-node-logger
branch
from
47f9c17 to
1edaa24
Compare
| @@ -0,0 +1,172 @@ | |||
| import stringifySafe from 'json-stringify-safe'; | |||
There was a problem hiding this comment.
copied from node-logger
There was a problem hiding this comment.
Okay so if I'm understanding correctly we are:
- depreciating node-logger and moving its functionality inside @node-opentelemetry
- also moving the winston and pino transports accordingly
- removing support for nest
This all looks good to me - are we no longer looking to also separate out the winston/pino transports into separate packages or just holding off? Doesn't seem necessary but I know you were mulling it over.
Briefly looking through I don't think this changes the README at all - but you can confirm 👍
Correct, we are going to have transport within the the same pkg for now and reevaluate if we want to migrate to official opentelemetry transport sdks. We are no longer to maintain the node-logger in the next release |
No description provided.