feat: introduce internal profiling #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ada530b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wrn14897
changed the title
wrn14897
commented
May 24, 2024
| diag.debug('Starting opentelemetry SDK'); | ||
| sdk.start(); | ||
|
|
||
| if (config.programmaticImports) { |
There was a problem hiding this comment.
moved this here since programmic-imports should only be enabled when api key or auth header is set
colehpage
approved these changes
May 24, 2024
Comment on lines
+97
to
+107
| const pickPerformanceIndicator = (hrt: [number, number]) => { | ||
| const speedInMs = hrtimeToMs(hrt); | ||
| if (speedInMs < 0.5) { | ||
| return '🚀'.repeat(3); | ||
| } else if (speedInMs < 1) { | ||
| return '🐌'.repeat(3); | ||
| } else { | ||
| return '🐢'.repeat(3); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
I almost want to not approve because you think snails are faster than turtles 😑
There was a problem hiding this comment.
Not my idea. guess who told me that 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
HDX_NODE_ENABLE_INTERNAL_PROFILINGto enable profiling, which is useful to debug instrumentation performance impact on the start time🚀 vs 🐌 vs 🐢 ??