Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose getSessionId + stopSessionRecorder + resumeSessionRecorder methods #173

Merged
merged 10 commits into from
Sep 6, 2024

Conversation

wrn14897
Copy link
Contributor

@wrn14897 wrn14897 commented Aug 28, 2024

  1. expose getSessionId + stopSessionRecorder + resumeSessionRecorder methods
  2. add recordCanvas + sampling options

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 4dd199a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperdx/browser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wrn14897 wrn14897 changed the title feat: expose deinit + getSessionId methods (WIP) feat: expose deinit + getSessionId methods Aug 28, 2024
@wrn14897 wrn14897 changed the title (WIP) feat: expose deinit + getSessionId methods feat: expose deinit + getSessionId + stopSessionRecorder + resumeSessionRecorder methods Aug 29, 2024
@wrn14897 wrn14897 changed the title feat: expose deinit + getSessionId + stopSessionRecorder + resumeSessionRecorder methods feat: expose getSessionId + stopSessionRecorder + resumeSessionRecorder methods Sep 5, 2024
@@ -191,6 +215,10 @@ class Browser {
Rum.setGlobalAttributes(attributes);
}

getSessionId(): string | undefined {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get this documented as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call! Let ma add it

@kodiakhq kodiakhq bot merged commit fbe054e into main Sep 6, 2024
3 checks passed
@kodiakhq kodiakhq bot deleted the warren/expose-deinit-n-get-session-id-methods branch September 6, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants