feat: Capture request, response headers and body #9
Conversation
ernestii
commented
May 29, 2024
•
ernestii
commented
- test on android
- test on ios
ernestii
force-pushed
the
ei/HDX-771-r
branch
2 times, most recently
from
17e67de to
06baa31
Compare
src/instrumentations/xhr.ts
Outdated
| const [key, value] = args; | ||
| const xhrMem = _xhrMem.get(this); | ||
| if (xhrMem && key && value) { | ||
| const newKey = `http.request.header.${key.toLowerCase()}`; |
There was a problem hiding this comment.
Let's try to make sure the headers extraction matches what otel does in their http instrumentation (https://github.com/open-telemetry/opentelemetry-js/blob/82b7526b028a34a23936016768f37df05effcd59/experimental/packages/opentelemetry-instrumentation-http/src/utils.ts#L583)
src/instrumentations/xhr.ts
Outdated
| 'http.request.body', | ||
| typeof requestBody === 'string' | ||
| ? requestBody | ||
| : JSON.stringify(requestBody) |
There was a problem hiding this comment.
better to handle the case when stringify throws. also I wonder if we want to set a cap on body size ?
src/instrumentations/xhr.ts
Outdated
| @@ -753,7 +780,28 @@ export function instrumentXHR(config: XhrConfig) { | |||
| } | |||
| } | |||
| } else if (this.readyState === XMLHttpRequest.DONE) { | |||
| endSpan(EventNames.EVENT_READY_STATE_CHANGE, this); | |||
| if (config.networkBodyCapture && this.responseType === 'blob') { | |||
| try { | |||
There was a problem hiding this comment.
probably leftover from experimenting, removed
| currentSpan.setAttribute('http.response.body', text); | ||
| }) | ||
| .finally(() => { | ||
| endSpan(EventNames.EVENT_READY_STATE_CHANGE, this); |
There was a problem hiding this comment.
just double check. the span would never end before this ?
src/instrumentations/xhr.ts
Outdated
| @@ -47,11 +47,14 @@ import type { PropagateTraceHeaderCorsUrls } from '@opentelemetry/sdk-trace-web/ | |||
|
|
|||
| const parseUrl = (url: string) => new URL(url); | |||
|
|
|||
| const MAX_BODY_LENGTH = 5 * 1024; // 5KB | |||
There was a problem hiding this comment.
5k seems a bit too strict. maybe something like 2MB to start with is okay
