fix incorrect split for select query #754
Conversation
|
| primaryKeys.trim() !== '' ? splitAndTrimCSV(primaryKeys) : []; | ||
| const allKeys = [...partitionKeyArr, ...primaryKeyArr]; | ||
| if (typeof select === 'string') { | ||
| const selectSplit = splitAndTrimCSV(select); |
There was a problem hiding this comment.
This is the root cause, make input:
JSONExtractString(Body, 'object', 'c'),JSONExtractString(Body, 'object', 'note')
become
["JSONExtractString(Body", "'object'", "'c')", "'note')"]
after dedupe set(selectColumns).
There was a problem hiding this comment.
Good find! have we thought about using module like csv-parse? (https://www.npmjs.com/package/csv-parse)
There was a problem hiding this comment.
I checked the csv-parse, however it does not work well with parentheses and brackets.
Parsing option quote only works for same character such as: "content", and it must at the beginning of the string, ex: "good", err"or".
There was a problem hiding this comment.
got it. in this case, I think we want to make sure the unit tests cover all use cases. Does it work with the select field like "foo,bar",field2,field3 as well?
There was a problem hiding this comment.
It will split it to:
[
'"foo',
'bar"',
'field2',
'field3'
]
It should works fine if we don't get the input like: "foo,bar","foo,differentBar",field2,field3 and also doing the dedupe.
There was a problem hiding this comment.
I will work on quote stuff, will update PR later.
There was a problem hiding this comment.
cool, I'd imagine the return value from the example above is ["foo,bar", "field2", "field3"] although it's a corner case
There was a problem hiding this comment.
update the split function to support single quote and double quote, feel free to check test case.
…-select-breaks-the-app
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
We should also replace |
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
…-select-breaks-the-app
| splitAndTrimCSV, | ||
| splitAndTrimWithBracket, | ||
| } from '@hyperdx/common-utils/dist/utils'; | ||
| import { splitAndTrimWithBracket } from '@hyperdx/common-utils/dist/utils'; |
There was a problem hiding this comment.
Granularity and splitAndTrimCSV is not used at here anymore, remove it since it cause conflict.
kodiakhq
bot
deleted the
mh/hdx-1587-bug-multiple-function-calls-in-the-select-breaks-the-app
branch
2 participants
Ref: hdx-1587