feat: compute charts ratio #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: adbcf22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
knudtty
reviewed
Apr 16, 2025
| const isRatio = | ||
| config.seriesReturnType === 'ratio' && | ||
| resultSets[0].meta?.length === 3; | ||
| return isRatio ? computeResultSetRatio(resultSets[0]) : resultSets[0]; |
Contributor
There was a problem hiding this comment.
Is this okay? computeResultSetRatio could throw but I don't see a try catch in this hook
Member
Author
There was a problem hiding this comment.
that's intentional. the error shouldn't break the app anyway
wrn14897
force-pushed
the
warren/implement-series-chart-ratio
branch
from
cbf1020 to
4be63e4
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: HDX-1607
Support ratio for both events and metrics charts