feat: queryChartConfig method + events chart ratio #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d97895 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wrn14897
commented
Apr 18, 2025
| import { buildMTViewSelectQuery } from '@/hdxMTViews'; | ||
| import { getMetadata } from '@/metadata'; | ||
|
|
||
| export const isMetric = (config: ChartConfigWithOptDateRange) => |
Member
Author
There was a problem hiding this comment.
Move all these to common-utils
wrn14897
force-pushed
the
warren/introduce-queryChartConfig-method
branch
from
f29b031 to
218fc8c
Compare
wrn14897
changed the title
knudtty
reviewed
Apr 21, 2025
| }), | ||
| ); | ||
|
|
||
| return isRatio |
| data: Array.from(tsBucketMap.values()), | ||
| }; | ||
| // TODO: we should compute the ratio on the db side | ||
| return isRatio ? computeResultSetRatio(_resultSet) : _resultSet; |
Contributor
There was a problem hiding this comment.
Isn't this moved to the db side now?
Member
Author
There was a problem hiding this comment.
for metrics, multi-series + ratio are still computed during post-query phase
knudtty
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: HDX-1631
queryChartConfigto handle multi-series chart (metrics specifically)seriesReturnTypeprop in chartConfig in the checkAlert file