Skip to content

fix: Not all console.error shows up in session replay play bar annotations #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Apr 30, 2025
Merged

fix: Not all console.error shows up in session replay play bar annotations #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0b1b0b
fix: Not all console.error shows up in session replay play bar annota…
ernestii Apr 19, 2025
583203a
comment: rename filteredEventsFilter -> highlightedEvents
ernestii Apr 30, 2025
69d9cee
feat: Improve Playbar - show same event marks as in the sidebar
ernestii Apr 30, 2025
b998797
Merge branch 'v2' into ernest/hdx-1457-bug-not-all-consoleerror-shows…
kodiakhq[bot] Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions packages/app/src/DOMPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,17 +513,18 @@ export default function DOMPlayer({
No replay available for this session, most likely due to this
session starting and ending in a background tab.
</div>
) : null}
<div
ref={wrapper}
className={cx(styles.domPlayerWrapper, 'overflow-hidden', {
'd-none': isLoading || isBuffering,
started: (replayer.current?.getCurrentTime() ?? 0) > 0,
[styles.domPlayerWrapperPaused]: playerState === 'paused',
})}
>
<div className="player rr-block" ref={playerContainer} />
</div>
) : (
Copy link
Contributor

@MikeShi42 MikeShi42 May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ernestii what's the reason of this change? This seems to break the replayer at times since playerContainer ref will be null in the useEffect above, seems to introduce a race condition where session replays will incorrectly show up as "no replay available"

<div
ref={wrapper}
className={cx(styles.domPlayerWrapper, 'overflow-hidden', {
'd-none': isLoading || isBuffering,
started: (replayer.current?.getCurrentTime() ?? 0) > 0,
[styles.domPlayerWrapperPaused]: playerState === 'paused',
})}
>
<div className="player rr-block" ref={playerContainer} />
</div>
)}
</div>
</>
);
Expand Down
4 changes: 4 additions & 0 deletions packages/app/src/Playbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,11 @@ export default function Playbar({
const isError =
event.severity_text?.toLowerCase() === 'error' ||
event.component === 'error' ||
event.component === 'console' ||
Copy link

Copilot AI Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-check whether the comparison to 'console' should include a case normalization (similar to the toLowerCase call for severity_text) to ensure that all variations of console errors are captured.

Suggested change
event.component === 'console' ||
event.component?.toLowerCase() === 'console' ||

Copilot uses AI. Check for mistakes.
statusCode >= 399;

const isSuccess = !isError && statusCode < 400 && statusCode > 99;

return {
id: event.id,
ts: event.startOffset,
Expand All @@ -93,6 +96,7 @@ export default function Playbar({
? 'Intercom Chat Opened'
: event.body,
isError,
isSuccess,
};
}) ?? [],
'percentage',
Expand Down
10 changes: 6 additions & 4 deletions packages/app/src/PlaybarSlider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as React from 'react';
import { format } from 'date-fns';
import { Slider, Tooltip } from '@mantine/core';

import { useFormatTime } from './useFormatTime';
Expand All @@ -12,6 +11,7 @@ export type PlaybarMarker = {
ts: number;
description: string;
isError: boolean;
isSuccess: boolean;
};

type PlaybarSliderProps = {
Expand Down Expand Up @@ -60,9 +60,11 @@ export const PlaybarSlider = ({
<div
className={styles.markerDot}
style={{
backgroundColor: mark.isError
? 'var(--mantine-color-red-6)'
: 'var(--mantine-color-gray-6)',
backgroundColor: mark.isSuccess
? 'var(--mantine-color-green-6)'
: mark.isError
? 'var(--mantine-color-red-6)'
: 'var(--mantine-color-gray-6)',
left: `${((mark.ts - min) / (max - min)) * 100}%`,
}}
onClick={() => onChange(mark.ts)}
Expand Down
13 changes: 8 additions & 5 deletions packages/app/src/SessionSubpanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,8 @@ export default function SessionSubpanel({
[traceSource],
);

const filteredEventsFilter = useMemo(
// Events shown in the highlighted tab
const highlightedEventsFilter = useMemo(
() => ({
type: 'lucene' as const,
condition: `${traceSource.resourceAttributesExpression}.rum.sessionId:"${rumSessionId}"
Expand Down Expand Up @@ -363,7 +364,7 @@ export default function SessionSubpanel({
offset: 0,
},
filters: [
filteredEventsFilter,
tab === 'highlighted' ? highlightedEventsFilter : allEventsFilter,
...(where ? [{ type: whereLanguage, condition: where }] : []),
],
}),
Expand All @@ -377,7 +378,9 @@ export default function SessionSubpanel({
end,
whereLanguage,
searchedQuery,
filteredEventsFilter,
tab,
highlightedEventsFilter,
allEventsFilter,
Copy link
Contributor

@teeohhem teeohhem Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ernestii just curious here...what is filteredEventsFilter vs allEventsFilter and why does this work? Can you add a few comments for future devs?

Copy link
Contributor Author

@ernestii ernestii Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filteredEventsFilter is used in the Highlighted tab – good point, updated the var name and added comment

Screenshot 2025-04-29 at 7 47 30 PM

where,
],
);
Expand Down Expand Up @@ -410,7 +413,7 @@ export default function SessionSubpanel({
offset: 0,
},
filters: [
tab === 'highlighted' ? filteredEventsFilter : allEventsFilter,
tab === 'highlighted' ? highlightedEventsFilter : allEventsFilter,
...(where ? [{ type: whereLanguage, condition: where }] : []),
],
}),
Expand All @@ -425,7 +428,7 @@ export default function SessionSubpanel({
whereLanguage,
searchedQuery,
tab,
filteredEventsFilter,
highlightedEventsFilter,
allEventsFilter,
where,
],
Expand Down
3 changes: 2 additions & 1 deletion packages/app/styles/PlaybarSlider.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@
position: absolute;
top: 0;
margin-left: -1px;
width: 3px;
width: 2px;
height: 8px;
background-color: #333;
border-radius: 1px;
opacity: 0.5;

&:hover {
opacity: 1 !important;
Expand Down