Skip to content

Conversation

@ernestii
Copy link
Contributor

@ernestii ernestii commented Apr 19, 2025

Screenshot 2025-04-18 at 10 08 00 PM

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2025

⚠️ No Changeset found

Latest commit: aa11098

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdx-v2-oss-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 4:39am

@ernestii ernestii requested a review from Copilot April 19, 2025 04:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces top-level filters for the Kubernetes Dashboard by adding a new KubernetesFilters component with selectable filter options and integrating it into the dashboard page.

  • Added a new FilterSelect component and KubernetesFilters component for dynamic filter extraction.
  • Updated the KubernetesDashboardPage to conditionally render the new filters based on the metric source.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/app/src/components/KubernetesFilters.tsx Introduces new filtering components and logic to extract filter values from the search query.
packages/app/src/KubernetesDashboardPage.tsx Integrates the new KubernetesFilters component into the dashboard layout.
Comments suppressed due to low confidence (1)

packages/app/src/components/KubernetesFilters.tsx:157

  • [nitpick] Consider adding unit tests for the updateSearchQuery helper function to ensure it correctly updates the search query under various scenarios, such as filtering multiple attributes or handling edge-case inputs.
const updateSearchQuery = (

Copy link
Member

@wrn14897 wrn14897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!

@kodiakhq kodiakhq bot merged commit 7693ff5 into v2 Apr 22, 2025
5 of 6 checks passed
@kodiakhq kodiakhq bot deleted the ernest/hdx-1542-top-level-filtering branch April 22, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants