Skip to content

Conversation

@ernestii
Copy link
Contributor

No description provided.

@ernestii ernestii requested a review from Copilot April 20, 2025 01:44
@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2025

⚠️ No Changeset found

Latest commit: 5a5a95a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdx-v2-oss-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 5:48pm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to open a detailed side panel for Kubernetes pod events by enhancing the PodDetailsSidePanel and PodLogs components.

  • Introduces new state management for tracking the selected row (rowId) and callbacks for handling row clicks and closing the nested side panel.
  • Refactors the DBSqlRowTable configuration using useMemo, and conditionally renders DBRowSidePanel based on row selection.
Comments suppressed due to low confidence (1)

packages/app/src/PodDetailsSidePanel.tsx:239

  • [nitpick] Consider renaming the parameter 'rowWhere' to 'rowId' for consistency with its usage and the prop name.
const handleRowClick = React.useCallback((rowWhere: string) => {

@ernestii ernestii force-pushed the ernest/hdx-1544-click-on-logs-table-should-open-an-event-details-side-panel-2 branch from c6f05d4 to 9a680ca Compare April 20, 2025 01:44
Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though was there a reason we didn't go for creating a generic DBSqlRowTableWithSidePanel component?

@kodiakhq kodiakhq bot merged commit b38668a into v2 Apr 21, 2025
5 of 6 checks passed
@kodiakhq kodiakhq bot deleted the ernest/hdx-1544-click-on-logs-table-should-open-an-event-details-side-panel-2 branch April 21, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants