-
Notifications
You must be signed in to change notification settings - Fork 339
feat: Open event details side panel from K8s Pod Events #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Open event details side panel from K8s Pod Events #770
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to open a detailed side panel for Kubernetes pod events by enhancing the PodDetailsSidePanel and PodLogs components.
- Introduces new state management for tracking the selected row (rowId) and callbacks for handling row clicks and closing the nested side panel.
- Refactors the DBSqlRowTable configuration using useMemo, and conditionally renders DBRowSidePanel based on row selection.
Comments suppressed due to low confidence (1)
packages/app/src/PodDetailsSidePanel.tsx:239
- [nitpick] Consider renaming the parameter 'rowWhere' to 'rowId' for consistency with its usage and the prop name.
const handleRowClick = React.useCallback((rowWhere: string) => {
c6f05d4 to
9a680ca
Compare
MikeShi42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though was there a reason we didn't go for creating a generic DBSqlRowTableWithSidePanel component?
…n-an-event-details-side-panel-2
No description provided.