This repository was archived by the owner on Feb 8, 2021. It is now read-only.
fix deadlock in ReleaseAllVms() #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiskyer
reviewed
Jan 19, 2017
| for _, p := range remains { | ||
| glog.V(1).Infof("try to dissociate %s", p.Id()) | ||
| if err := p.Dissociate(); err != nil { | ||
| glog.V(1).Infof("fail to dissociate %s: %v", p.Id(), err) |
There was a problem hiding this comment.
log as warning instead of info?
feiskyer
reviewed
Jan 19, 2017
| for _, p := range remains { | ||
| glog.V(1).Infof("try to dissociate %s", p.Id()) | ||
| if err := p.Dissociate(); err != nil { | ||
| glog.V(1).Warningf("fail to dissociate %s: %v", p.Id(), err) |
Foreach() holds the reader-lock for the podlist, but p.Dissociate() reqired the writer-lock to remove the containers, it results deadlock. Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foreach() holds the reader-lock for the podlist,
but p.Dissociate() reqired the writer-lock to remove the containers,
it results deadlock.
Signed-off-by: Lai Jiangshan jiangshanlai@gmail.com