Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitions to avoid ambiguity:
crates/hyperion/src/simulation/event.rs
that are currently processed throughEventQueue
events/
, such as thetag
eventEvents are mostly repackaged Valence packets with some processing, which can easily be done in the event code. Custom events can also already be sent through
HandlerRegistry
, and keeping the separate events system adds confusion on which system to use. In addition, theEventQueue
approach requires allocations and requires us to maintainRuntimeLifetime
, which cannot be checked at compile time and causes aborts at runtime if used improperly while theHandlerRegistry
does not require allocations to send events and can send events with references to the original packet data that is completely checked at compile time. This PR removes the events system.