Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WLED device should not turn automatically off after hyperion shutdown #1095

Closed
ProtoxiDe22 opened this issue Nov 16, 2020 · 2 comments
Closed
Assignees

Comments

@ProtoxiDe22
Copy link

Feature request

First of all, i don't really know if this should have been a feature request or bug report, it's is kinda in the middle.
It seems like that when WLED was implemented in Hyperion as a controller type, a new feature was added, that automatically shuts down the WLED device when Hyperion is closed, this is not always a desidered behaviour, as the user might want to use WLED's lighting when Hyperion is not active.
This has been discussed in Aircoookie/WLED#1308 and it seems like the past behaviour was different (as in, WLED would stay on after Hyperion shut down)

What problem does this feature solve?

This would allow to seamlessly interchange between the use of Hyperion and WLED, for those users who only want to use Hyperion for ambient lighting when using certain aplications

What does the proposed API look like?

N/A (at least i think so)

How should this be implemented in your opinion?

I think the best approach to this would be to have this behaviour configurable in the controller settings, there should be a flag, or something similar, that specifies if WLED should be turned off or not after Hyperion's shutdown

Are you willing to work on this yourself?

I'm not knowledgeable enough on this feature

@ProtoxiDe22 ProtoxiDe22 changed the title WLED turning off after hyperion shutdown WLED device should not turn automatically off after hyperion shutdown Nov 16, 2020
@Aircoookie
Copy link

@HyperionNG devs: First of all, thank you very much for adding an integration for my software to Hyperion.NG :) That's awesome!

Here is my proposal for the in my opinion ideal behavior. Maybe there are better options though, like a user config option.

@Lord-Grey
Copy link
Collaborator

I will have a look at the topic...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants