Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Device Selection/Configuration #1164

Merged
merged 55 commits into from
Apr 24, 2021

Conversation

Lord-Grey
Copy link
Collaborator

@Lord-Grey Lord-Grey commented Jan 24, 2021

Summary

New Features

UI Optimization

  • Select device from list of available devices (UI Optimization - Select device from list of available devices #1053) - Cololight, Nanoleaf, Serial Devices (e.g. Adalight), SPI-Device, Pi-Blaster
  • Get device properties for automatic configuration of number of LEDs and initial layout (WLED, Cololight, Nanoleaf)
  • Identify/Test device (WLED, Cololight, Nanoleaf, Adalight)
  • For selected devices a default layout configuration is created, if the user chooses "Overwrite" (WLED, Cololight, Nanoleaf, all serial devices, all spi device, pi-blaster)
  • Ensure Hardware LED count matches number of lights (Philips Hue, Yeelight, Atmo Orb)
  • Allow to blacklist LEDs in layout via UI

Improvements

  • User is presented a warning/error, if there is a mismatch between configured LED number and available hardware LEDs
  • WLED - Brightness overwrite control by configuration
  • WLED - Allow to disable WLED synchronization when streaming via hyperion
  • Storing of current version in database
  • Support migration activities related to versions
  • Move migration activities out of UI-JS code into backend (for ledConfig)

Fixes

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

image

image

image

image

image

image

Blacklisting LEDs

image

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Fixes #1053 , #1095, #673

@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@lgtm-com
Copy link

lgtm-com bot commented Apr 8, 2021

This pull request introduces 2 alerts and fixes 6 when merging a94cc5e into a3c8fba - view on LGTM.com

new alerts:

  • 2 for Missing variable declaration

fixed alerts:

  • 6 for Unused variable, import, function or class

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@lgtm-com
Copy link

lgtm-com bot commented Apr 10, 2021

This pull request introduces 2 alerts and fixes 6 when merging 99420db into 6f0ccdb - view on LGTM.com

new alerts:

  • 2 for Missing variable declaration

fixed alerts:

  • 6 for Unused variable, import, function or class

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@lgtm-com
Copy link

lgtm-com bot commented Apr 10, 2021

This pull request introduces 2 alerts and fixes 6 when merging 5b17436 into 6f0ccdb - view on LGTM.com

new alerts:

  • 2 for Missing variable declaration

fixed alerts:

  • 6 for Unused variable, import, function or class

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@lgtm-com
Copy link

lgtm-com bot commented Apr 10, 2021

This pull request fixes 6 alerts when merging 361f621 into 6f0ccdb - view on LGTM.com

fixed alerts:

  • 6 for Unused variable, import, function or class

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@lgtm-com
Copy link

lgtm-com bot commented Apr 11, 2021

This pull request fixes 6 alerts when merging f54791d into 6f0ccdb - view on LGTM.com

fixed alerts:

  • 6 for Unused variable, import, function or class

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@lgtm-com
Copy link

lgtm-com bot commented Apr 11, 2021

This pull request fixes 6 alerts when merging 5763dd4 into 6f0ccdb - view on LGTM.com

fixed alerts:

  • 6 for Unused variable, import, function or class

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@lgtm-com
Copy link

lgtm-com bot commented Apr 11, 2021

This pull request fixes 6 alerts when merging 8d19154 into 6f0ccdb - view on LGTM.com

fixed alerts:

  • 6 for Unused variable, import, function or class

@Paulchen-Panther Paulchen-Panther merged commit 7eeb740 into hyperion-project:master Apr 24, 2021
@Lord-Grey Lord-Grey deleted the Device_Selections branch November 20, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Optimization - Select device from list of available devices
2 participants