Tpm2net incorrect calculation of total packet numbers

[mlaurijsse]

• I confirm that this is an issue rather than a question.

Bug report

When using a tpm2net led device the total number of packets is incorrectly calculated when Max packet is chosen such that all packets are equal size (i.e. the last packet size is equal to the Max packet size).

The root of the error lies in line 26 of LedDeviceTpm2net.cpp. It should round up to the nearest integer instead of rounding down (casting to int) and adding 1.

If needed, I can generate a pull request to fix this bug.

Steps to reproduce

For example: set Hardware LED count to 600 leds, and Max packet 900

What is expected?

600 leds * 3 bytes = 1800 bytes of data
1800 / 900 = 2 packets in total
Two packets being sent, packet header describing a total of 2 packets.

What is actually happening?

Two packets are actually sent, but the packet header is stating a total of 3 packets. This causes the receiver to expect a third packet, which never arrives. Hence the receiver is not processing the data.

System

Hyperion Server:

• Build: (HEAD detached at 83338dc) (Paulchen Panther-ca50487e/83338dc3-1605733041)
• Build time: Nov 18 2020 21:34:12
• Git Remote: https://github.com/hyperion-project/hyperion.ng
• Version: 2.0.0-alpha.9
• UI Lang: auto (BrowserLang: en-US)
• UI Access: expert
• Avail Capt: dispmanx,v4l2,framebuffer,qt
• Database: read/write

Hyperion Server OS:

• Distribution: Raspbian GNU/Linux 10 (buster)
• Architecture: arm
• CPU Model: ARMv7 Processor rev 3 (v7l)
• CPU Type: Raspberry Pi 4 Model B Rev 1.2
• CPU Revision: c03112
• CPU Hardware: BCM2711
• Kernel: linux (5.4.72-v7l+ (WS: 32))
• Qt Version: 5.7.1
• Python Version: 3.5.3
• Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.67 Safari/537.36

[Lord-Grey]

@mlaurijsse Thanks for reporting.

If you could do a pull request would be very much appreciated.

Thank you!