Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: display argument in hyperion-qt #1027

Merged
merged 3 commits into from
Oct 18, 2020

Conversation

Denrage
Copy link
Contributor

@Denrage Denrage commented Oct 4, 2020

Summary
This fixes the display argument in hyperion-qt, so it actually uses the display given to the program through argument.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@hyperion-project
Copy link

Hello @Denrage 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Lord-Grey
Copy link
Collaborator

@Denrage Thanks for your contribution!

If Display can always be an integer only, then this fix should be applied to other grabbers with "Display" too,
Could you also fix hyperion-osx.cpp?

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Denrage
Copy link
Contributor Author

Denrage commented Oct 9, 2020

I fixed it for osx too. Am i able to test it without a mac?

@Lord-Grey
Copy link
Collaborator

@tpmodding Could you Test the fix on MacOS?

@tpmodding tpmodding self-requested a review October 9, 2020 16:28
@tpmodding
Copy link
Collaborator

tpmodding commented Oct 9, 2020

works
Bildschirmfoto 2020-10-09 um 18 39 34

@Paulchen-Panther
Copy link
Member

I thank you on behalf of everyone for your help.

@Paulchen-Panther Paulchen-Panther merged commit 02d0ab6 into hyperion-project:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants