-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: display argument in hyperion-qt #1027
FIX: display argument in hyperion-qt #1027
Conversation
Hello @Denrage 👋 I'm your friendly neighborhood bot and would like to say thank you for So that you and other users can test your changes more quickly, If you make changes to your PR, i create a new link to your workflow artifacts. Best regards, |
Here is your new link to your workflow artifacts. |
@Denrage Thanks for your contribution! If Display can always be an integer only, then this fix should be applied to other grabbers with "Display" too, |
Here is your new link to your workflow artifacts. |
I fixed it for osx too. Am i able to test it without a mac? |
@tpmodding Could you Test the fix on MacOS? |
I thank you on behalf of everyone for your help. |
Summary
This fixes the display argument in hyperion-qt, so it actually uses the display given to the program through argument.
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: