Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectX9 Grabber #1039

Merged
merged 8 commits into from
Oct 26, 2020
Merged

Conversation

Paulchen-Panther
Copy link
Member

Summary

The title says it all.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@hyperion-project
Copy link

Hello @Paulchen-Panther 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

Copy link

@DonaldTrump-2020 DonaldTrump-2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have to change from RGB to BGR to correct colororder rgb. byteRGB wizard cannot fix it!

CMakeLists.txt Show resolved Hide resolved
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther
Copy link
Member Author

Paulchen-Panther commented Oct 13, 2020

i have to change from RGB to BGR to correct colororder rgb. byteRGB wizard cannot fix it!

@DonaldTrump-2020
can you show me the code where you changed the order from rgb to bgr? is the image preview displayed correctly on the webUi or have the colors been swapped? a screenshot would help me a lot!

@DonaldTrump-2020
Copy link

Capture
yes, here you are.

@Paulchen-Panther
Copy link
Member Author

Paulchen-Panther commented Oct 14, 2020

@DonaldTrump-2020

yes, here you are.

  1. What the hell does the LED byte sequence have to do with the DirectX Grabber?
  2. You didn't answer my other questions.
  3. Without further details, there is nothing I can do for you.

@DonaldTrump-2020
Copy link

DonaldTrump-2020 commented Oct 14, 2020

I meant when i use directx9 grabber, i have to change this byteRGB from RGB to BGR to correct color order.

With QT grabber on windows, i can still use RGB for color order, but with directX9 I can not

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther
Copy link
Member Author

@DonaldTrump-2020
I corrected the color sequence. Next time just post a screenshot as requested and answer all the questions asked before. Then it is also quicker.

@DonaldTrump-2020
Copy link

Thank you bro. I will do it next time

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther Paulchen-Panther merged commit 1d35338 into hyperion-project:master Oct 26, 2020
@Paulchen-Panther Paulchen-Panther deleted the directx branch November 8, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants