Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PR #957 #1234

Merged
merged 22 commits into from
May 1, 2021
Merged

Conversation

Paulchen-Panther
Copy link
Member

@Paulchen-Panther Paulchen-Panther commented Apr 25, 2021

Summary

Since the current documentation and the forum have already been redesigned, it is time to adapt the main component. As a bonus, feature request #1136 has been implemented.
A BIG thanks goes to our graphic designer @mkcologne .

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

ReDesign WebUI to reflect the current design

If changing the UI of web configuration, please provide the before/after screenshot:

Example screenshots of old WebUI vs. new WebUI
https://screenshotcomparison.com/comparison/13460/

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
Closes #1136

@hyperion-project
Copy link

Hello @Paulchen-Panther 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@lgtm-com
Copy link

lgtm-com bot commented Apr 29, 2021

This pull request fixes 1 alert when merging 113f821 into 71e34a6 - view on LGTM.com

fixed alerts:

  • 1 for Variable not declared before use

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@lgtm-com
Copy link

lgtm-com bot commented Apr 30, 2021

This pull request introduces 1 alert and fixes 10 when merging c8acd2c into 71e34a6 - view on LGTM.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 5 for Wrong type of arguments to formatting function
  • 2 for Unused variable, import, function or class
  • 1 for Variable not declared before use
  • 1 for Missing variable declaration
  • 1 for Binding a socket to all network interfaces

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project hyperion-project deleted a comment from hyperion-project bot Apr 30, 2021
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@lgtm-com
Copy link

lgtm-com bot commented Apr 30, 2021

This pull request introduces 1 alert and fixes 9 when merging 9a169e5 into 71e34a6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 5 for Wrong type of arguments to formatting function
  • 2 for Unused variable, import, function or class
  • 1 for Variable not declared before use
  • 1 for Missing variable declaration

instance panel always visible
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@lgtm-com
Copy link

lgtm-com bot commented May 1, 2021

This pull request fixes 9 alerts when merging 61c3c8b into 71e34a6 - view on LGTM.com

fixed alerts:

  • 5 for Wrong type of arguments to formatting function
  • 2 for Unused variable, import, function or class
  • 1 for Variable not declared before use
  • 1 for Missing variable declaration

restore main_nav position after switching Destop/Mobile
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther Paulchen-Panther merged commit 17d4406 into hyperion-project:master May 1, 2021
@lgtm-com
Copy link

lgtm-com bot commented May 1, 2021

This pull request fixes 9 alerts when merging 1b783cd into 71e34a6 - view on LGTM.com

fixed alerts:

  • 5 for Wrong type of arguments to formatting function
  • 2 for Unused variable, import, function or class
  • 1 for Variable not declared before use
  • 1 for Missing variable declaration

@Paulchen-Panther Paulchen-Panther deleted the webui branch March 15, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Live Video image to LedLayout preview
2 participants