Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct PR1312 and LEDSim fixes #1336

Merged
merged 6 commits into from
Sep 20, 2021

Conversation

Lord-Grey
Copy link
Collaborator

Summary

  • Refactor/Optimization: Load configuration of last instance used when loading the UI page
  • Refactor: Streamline API requests to avoid unnecessary invocations (Correct issue introduced by PR1213)
  • Disable LED update streaming, if LED updates are not required
  • Sync. Video-Streaming between Layout and Simulation

UI page initialisation sequence

content_index.js - document.ready
initWebSocket()
-> websocket.onopen
	trigger open
-> open
	requestRequiresAdminAuth()
	-> cmd-authorize-adminRequired
	requestRequiresDefaultPasswortChange()
	-> cmd-authorize-newPasswordRequired
		requestAuthorization()/requestTokenAuthorization()
	-> cmd-authorize-login
		requestServerConfigSchema()
		-> cmd-config-getschema
			requestTokenInfo();
			requestGetPendingTokenRequests();

			instanceSwitch()
				requestInstanceSwitch()
				(updateHyperionInstanceListing)
				-> cmd-instance-switchTo
					requestServerConfig()
					-> cmd-config-getconfig
					requestServerInfo()
					-> cmd-serverinfo
						trigger("ready")
						-> ready (one)
						  ...

					requestTokenInfo()
					->cmd-authorize-tokenRequest
					
					loadContent()

			requestSysInfo()
			-> cmd-sysinfo

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
Corrects #1312

@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@Lord-Grey Lord-Grey changed the title Correct pr1312 Correct PR1312 and LEDSim fixes Sep 19, 2021
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Lord-Grey Lord-Grey merged commit 8134917 into hyperion-project:master Sep 20, 2021
@Lord-Grey Lord-Grey deleted the Correct_PR1312 branch November 20, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant