Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WLED segment streaming support #1556

Merged
merged 7 commits into from
Feb 7, 2023
Merged

WLED segment streaming support #1556

merged 7 commits into from
Feb 7, 2023

Conversation

Lord-Grey
Copy link
Collaborator

@Lord-Grey Lord-Grey commented Jan 6, 2023 •
edited
Loading

Summary

Added

  • Support streaming to individual WLED segments (requires WLED 0.13.3+).
    To allow segment streaming, enable "Realtime - Use main segment only" in WLED's Sync Interfaces setup screen
  • Allow to keep WLED powered on after streaming and restoring state

Changed

  • LED Devices: Allow to differentiate between recoverable/unrecoverable errors

Fixed

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

After

image

image

Segment streaming disabled at WLED

image

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
Fixes #1566

@Lord-Grey Lord-Grey self-assigned this Jan 6, 2023
@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm the Hyperion Project Bot and I want to thank you for
contributing to Hyperion with your pull requests!

To help you and other users test your pull requests faster,
I'll create a link for you to your workflow artifacts.

🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/3855251175

Of course, if you make changes to your PR, I will create a new link.

Best regards,
Hyperion Project

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 6, 2023
View reviewed changes
assets/webconfig/js/ui_utils.js Fixed Show fixed Hide fixed
assets/webconfig/js/content_leds.js Fixed Show fixed Hide fixed
assets/webconfig/js/content_leds.js Fixed Show fixed Hide fixed
assets/webconfig/js/content_leds.js Fixed Show fixed Hide fixed
assets/webconfig/js/content_leds.js Fixed Show fixed Hide fixed
assets/webconfig/js/ui_utils.js Fixed Show fixed Hide fixed
@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/3856417434

@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/4097866283

@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/4097953074

@hyperion-project
Copy link

Hey @Lord-Grey I created a new link to your workflow artifacts:
🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/4106699444

@Lord-Grey Lord-Grey mentioned this pull request Feb 6, 2023
Closed
1 task
@Lord-Grey Lord-Grey merged commit a57bcbc into hyperion-project:master Feb 7, 2023
@Lord-Grey Lord-Grey deleted the WLED branch February 10, 2023 19:22
asturel pushed a commit to asturel/hyperion.ng that referenced this pull request Feb 11, 2023
@Lord-Grey @asturel
WLED segment streaming support (hyperion-project#1556)
814de20 
* WLED segment streaming support

* Address CodeQL findings

* WLED - Remove that interim color is shown when WLED is powered off

* Allow LEDDevice to stay on after streaming

* Apply stayOn on segment streamed to

* Fix LED-Matrix Layout: Add Cabling direction selection element again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Lord-Grey Lord-Grey

Labels
Enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LED Matrix Vertical Cabling Direction not working
1 participant
@Lord-Grey