Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ftdi led device - 2 #1746

Merged
merged 51 commits into from
May 31, 2024
Merged

Conversation

Lord-Grey
Copy link
Collaborator

@Lord-Grey Lord-Grey commented May 27, 2024

Summary

This PR reflects @nurikk / @nurikk-sa ftdi development without the jointup of the SPI and ftdi device code (see #1595).

The PR introduces ftdilib1 led device implementation. FTDI chips are common usb2serial/spi/whatever chips, and are available for 5-10$ from Chinese website as various breakout boards.

Screenshot 2023-02-25 at 21 52 19

My wiring is following:

FTDI  |  APA102 
AD0 -> CLOCK
AD1 -> DATA

AD3 -> CS (active low) // can be used to drive logic shifter OE pins


FTDI  |  WS2812 or SK6812
AD1 -> DATA

AD3 -> CS (active low) // can be used to drive logic shifter OE pins

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@Lord-Grey Lord-Grey mentioned this pull request May 27, 2024
9 tasks
@nurikk
Copy link

nurikk commented May 30, 2024

Terrific! I'm glad that this will get to upstream! 👍

@Lord-Grey
Copy link
Collaborator Author

@nurikk Please have a look, if you would like to add something.
Otherwise, I will merge with the master.

@Lord-Grey Lord-Grey merged commit 76fff98 into hyperion-project:master May 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants