-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Led Matrix Layout - Save/Restore (#669) #697
Conversation
Hier der Code... Kannst Du bitte mal schauen, was ggf. angepasst werden muss, damit die Fehlermeldungen nicht kommen. Details findest zu im Issue #669. |
|
Moment ich schaue ... |
Halt alles zurück, die Daten sind falsch |
??? |
requestWriteConfig() läuft durch das übergebene object, dadurch kann man auch mehrere Teile der config auf einmal überschreiben. Da das ledConfig object selbst gefehlt hat, nimmt er matrix und classic und fügt sie als root element hinzu, der schema checker bemängelt das dann. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
Summary
Save and Restore Led Matrix Layout
including the migration form old to new data structure.
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfils these requirements:
Fixes: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
Addresses #669