Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Led Matrix Layout - Save/Restore (#669) #697

Merged
merged 2 commits into from
Feb 22, 2020

Conversation

Lord-Grey
Copy link
Collaborator

Summary

Save and Restore Led Matrix Layout
including the migration form old to new data structure.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfils these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
Addresses #669

@Lord-Grey
Copy link
Collaborator Author

@brindosch

Der settingsManager wird die Daten immer an das schema angleichen. Es kann sein, dass da evtl ein Fehler drin ist.
Vielleicht einen PR erstellen, dann kann man es direkt einsehen und editieren.

Hier der Code...

Kannst Du bitte mal schauen, was ggf. angepasst werden muss, damit die Fehlermeldungen nicht kommen. Details findest zu im Issue #669.

@brindosch
Copy link
Contributor

brindosch commented Feb 22, 2020

Es ist offensichtlich, ich finde den Fehler aber nicht.
@Paulchen-Panther , als Meister des Schemas hast du da unter Umständen einen besseren Durchblick

Der Pfad ist falsch, ich sehe aber nicht wieso. [root].classic sollte [root].ledConfig.classic sein.

@Paulchen-Panther
Copy link
Member

Moment ich schaue ...

@brindosch
Copy link
Contributor

Halt alles zurück, die Daten sind falsch

@Paulchen-Panther
Copy link
Member

Halt alles zurück, die Daten sind falsch

???

@brindosch
Copy link
Contributor

requestWriteConfig() läuft durch das übergebene object, dadurch kann man auch mehrere Teile der config auf einmal überschreiben. Da das ledConfig object selbst gefehlt hat, nimmt er matrix und classic und fügt sie als root element hinzu, der schema checker bemängelt das dann.

@brindosch brindosch self-requested a review February 22, 2020 23:48
Copy link
Contributor

@brindosch brindosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@brindosch brindosch linked an issue Feb 22, 2020 that may be closed by this pull request
@brindosch brindosch linked an issue Feb 22, 2020 that may be closed by this pull request
@brindosch brindosch merged commit a2dbbcd into hyperion-project:master Feb 22, 2020
@Lord-Grey Lord-Grey deleted the #669 branch April 13, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Led Matrix Layout page does not consider last layout saved
3 participants