-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve language selection usability #812
Improve language selection usability #812
Conversation
Hello @Lord-Grey 👋 I'm your friendly neighborhood bot and would like to say thank you for So that you and other users can test your changes more quickly, If you make changes to your PR, i create a new link to your workflow artifacts. Best regards, |
Thank you for this addition, because space is limitted at the top bar, i would keep it at least in the dropdown. (open on smartphone and you will see what i mean) |
Yes, sure. I tested without multiple hyperion instances and it looked ok. |
@brindosch Done. |
Here is your new link to your workflow artifacts. |
Can we still implement this somehow? The reason for this is this: https://prnt.sc/sqajsv Many Thanks |
I will have a look. Seems I need to test with fresh install. What is the envisioned default language, if one cannot be resolved? I would assume English. Having the default right should fix the issue. |
Ich glaube es wird die Sprache des Browsers (OS) genommen!?! edit: Nach Löschung der Cookies wird bei mir die deutsch Sprache verwendet. Angezeigt wird aber "Nothing selected" edit2: Ich glaube die Sprache wird hier ausgewählt: https://github.com/hyperion-project/hyperion.ng/blob/master/assets/webconfig/js/settings.js#L30 edit3: sessionStorage: https://developer.mozilla.org/de/docs/Web/API/Window/sessionStorage |
Das translation handling wird von jquery.i18n verwaltet und wie @Paulchen-Panther schon festgestellt hat. Es gibt nicht viel code dazu :) Bei weiteren Fragen.. fragen :) |
So jetzt sollte es funktionieren... Logik ist:
|
Funktioniert wunderbar. Vielen Dank für die Nachbesserung. 👍 |
Und ich dachte erst, dass ist mal was für einen Abend.... |
Ja, das kenne ich. 🤣 |
Here is your new link to your workflow artifacts. |
@brindosch Thank you! |
Here is your new link to your workflow artifacts. |
Ready to merge? |
Yes |
Improve the language selection user experience according to UX best practices.
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Before
After
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
Addresses issue: #787