Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress default password warning #830

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Suppress default password warning #830

merged 3 commits into from
Jun 26, 2020

Conversation

Lord-Grey
Copy link
Collaborator

Summary

Allow the user to suppress default password warning,
in case they are happy to run hyperion without password access.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Before

image

After
image

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@Lord-Grey Lord-Grey requested a review from brindosch June 13, 2020 11:00
@Lord-Grey Lord-Grey self-assigned this Jun 13, 2020
@Paulchen-Panther
Copy link
Member

I like it. ❤️

@Paulchen-Panther
Copy link
Member

Ready to merge?

@Paulchen-Panther Paulchen-Panther merged commit 1744f6d into hyperion-project:master Jun 26, 2020
@brindosch
Copy link
Contributor

Anstrengend, jetzt werfe ich schon meine selbst erstellten Konventionen ins Meer.
Gerne die CHANGELOG.md in der Unreleased Sektion beglücken.

@Paulchen-Panther
Copy link
Member

Ich verstehe kein Wort von dem was du uns sagen wolltest aber EGAL. 😄

@brindosch
Copy link
Contributor

Wir haben eine CHANGELOG.md im repo, in der alles "wichtige" festgehalten werden soll. Dann sitzt man beim nächsten Release nicht mehr dran alle commits durchzusehen nach wichtigen Notizen.

@tpmodding
Copy link
Collaborator

#833 einfach hier ergänzen :-)

@brindosch
Copy link
Contributor

Ah, schon in den Brunnen gefallen :)

@Lord-Grey Lord-Grey deleted the SuppressPwWarning branch July 12, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindosch brindosch brindosch approved these changes

Assignees

@Lord-Grey Lord-Grey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lord-Grey @Paulchen-Panther @brindosch @tpmodding