Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Windows console window #860

Merged
merged 7 commits into from
Jul 12, 2020

Conversation

brindosch
Copy link
Contributor

Summary

Windows: Add option -c to hyperiond to create a console window with log output

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther
Copy link
Member

Richtig gut wäre noch eine Verknüpfung im Startmenü von Windows. Dann sehen die User auch das es diese Variante gibt. Und im Fehlerfall ist es leichter zu erklären, die Konsolen Version starten zu lassen.
Nichts desto trotz. Vielen Dank für dein Beitrag. 👍

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther
Copy link
Member

Ein dickes 👍 für dich.

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@brindosch
Copy link
Contributor Author

brindosch commented Jul 1, 2020

NSIS vcredist:
Als Basis hab ich die Implementierung aus dem nullsoft forum genommen. Davon ist nichts mehr übrig, weil seit 2015 man nur noch über die build nr gehen kann und keine neue major version mehr erscheint (Binär kompatibel)

Nach rund 2h sage ich: Es funktioniert einfach nicht zuverlässig. Wenn ich zb vcredist deinstalliere dann bleibt der reg key so bestehen. Jede Arbeit die man weiter rein steckt es ist wohl nicht Wert (Weil die install in wenigen ms durchgerannt ist)

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther
Copy link
Member

Vielen Dank für deine Arbeit. 👍

@Paulchen-Panther Paulchen-Panther merged commit de9ece5 into hyperion-project:master Jul 12, 2020
@brindosch brindosch deleted the winconsole branch July 13, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants