Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows debug builds for PR artifacts #866

Closed

Conversation

Paulchen-Panther
Copy link
Member

@Paulchen-Panther Paulchen-Panther commented Jul 6, 2020

Summary

With this PR, Windows debug build artifacts are created. This should make it easier to find errors.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@hyperion-project
Copy link

Hello @Paulchen-Panther 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@Paulchen-Panther Paulchen-Panther changed the title Debug builds for PR artifacts Windows debug builds for PR artifacts Jul 6, 2020
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther Paulchen-Panther marked this pull request as draft July 6, 2020 20:59
@brindosch
Copy link
Contributor

Cool :)
Hint: actions/setup-python#86

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther
Copy link
Member Author

@brindosch
Über jegliche Hilfe bin ich sehr dankbar. 👍

@Paulchen-Panther
Copy link
Member Author

I will put this PR on hold for now. Since some debug dependencies are not available in vcredist, debugging under Windows without VS proves difficult.

@Paulchen-Panther Paulchen-Panther deleted the debug branch July 12, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants