Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS/Systray option to launch Hyperion on Windows start [HKCU] #887

Merged

Conversation

Paulchen-Panther
Copy link
Member

@Paulchen-Panther Paulchen-Panther commented Jul 19, 2020

Summary

The title actually says it all.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

NSIS

Systray

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@hyperion-project
Copy link

Hello @Paulchen-Panther 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@Paulchen-Panther Paulchen-Panther changed the title NSIS/Systray option to launch Hyperion on Windows start NSIS/Systray option to launch Hyperion on Windows start [HKCU] Jul 19, 2020
@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Paulchen-Panther Paulchen-Panther marked this pull request as draft July 19, 2020 17:58
@Paulchen-Panther Paulchen-Panther linked an issue Jul 19, 2020 that may be closed by this pull request
@Paulchen-Panther Paulchen-Panther added new feature WIP Work in Progress labels Jul 19, 2020
@tihoangyeudau
Copy link

tihoangyeudau commented Jul 20, 2020

applicationFilePath(): this function returned in regedit:
C:/Program Files/Hyperion/bin/hyperiond.exe instead of C:\Program Files\Hyperion\bin\hyperiond.exe in String "Hyperion", so i cant disable/enable autostart.

I solved it by the way: change qApp->applicationFilePath() to qApp->applicationFilePath().replace('/', '\\')

@Paulchen-Panther
Copy link
Member Author

Thank you for the feedback. Corrected it. 👍

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@brindosch
Copy link
Contributor

Tested and works as intended
Win10

  • NSIS autostart link
  • Systray enable
  • Systray disable

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@brindosch
Copy link
Contributor

brindosch commented Aug 1, 2020

The icon option might be another issue/pr. As we need to decide about an icon theme (if so)

@Paulchen-Panther
Copy link
Member Author

You're right. We should use the same symbols on all patforms.

@Paulchen-Panther Paulchen-Panther marked this pull request as ready for review August 1, 2020 14:51
@Paulchen-Panther Paulchen-Panther removed the WIP Work in Progress label Aug 1, 2020
@Paulchen-Panther
Copy link
Member Author

Dann würde ich diesen PR jetzt mergen.
Vielen Dank an alle Tester.

@Paulchen-Panther Paulchen-Panther merged commit 7550a93 into hyperion-project:master Aug 1, 2020
@Paulchen-Panther Paulchen-Panther deleted the run-on-boot branch August 31, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows autostart feature
3 participants