Fix some more threading errors #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @m-seker 👋 I'm your friendly neighborhood bot and would like to say thank you for So that you and other users can test your changes more quickly, If you make changes to your PR, i create a new link to your workflow artifacts. Best regards, |
m-seker
commented
Jul 26, 2020
| @@ -548,6 +540,4 @@ private slots: | |||
|
|
|||
| /// Boblight instance | |||
| BoblightServer* _boblightServer; | |||
|
|
|||
| QMutex _changes; | |||
There was a problem hiding this comment.
See the cpp for why I removed
| @@ -190,8 +191,6 @@ void Hyperion::handleSettingsUpdate(const settings::type& type, const QJsonDocum | |||
| } | |||
| else if(type == settings::LEDS) | |||
| { | |||
| QMutexLocker lock(&_changes); | |||
There was a problem hiding this comment.
All the functions protected by this mutex (handleSettingsUpdate and update) is called from Hyperion's own thread. No need to synchronize.
m-seker
requested review from
Lord-Grey,
brindosch,
Paulchen-Panther and
tpmodding
and removed request for
Lord-Grey and
brindosch
m-seker
force-pushed
the
bugfix/more_threading
branch
from
430145f
to
0115986
Compare
Lord-Grey
approved these changes
Aug 2, 2020
Paulchen-Panther
approved these changes
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As the title says.
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: