Modernize Qt connections #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-seker
commented
Jul 27, 2020
| @@ -398,8 +398,6 @@ public slots: | |||
| /// | |||
| void currentImage(const Image<ColorRgb> & image); | |||
|
|
|||
| void closing(); | |||
There was a problem hiding this comment.
Let's remove dead code....
|
Hello @m-seker 👋 I'm your friendly neighborhood bot and would like to say thank you for So that you and other users can test your changes more quickly, If you make changes to your PR, i create a new link to your workflow artifacts. Best regards, |
m-seker
commented
Jul 27, 2020
| { | ||
| // switch off all leds | ||
| clear(-1,true); | ||
|
|
||
| if (emitCloseSignal) | ||
| { | ||
| emit closing(); |
There was a problem hiding this comment.
Let's remove dead code....
m-seker
commented
Jul 27, 2020
| @@ -17,8 +17,6 @@ LedDevicePiBlaster::LedDevicePiBlaster(const QJsonObject &deviceConfig) | |||
|
|
|||
| _activeDeviceType = deviceConfig["type"].toString("UNSPECIFIED").toLower(); | |||
|
|
|||
| signal(SIGPIPE, SIG_IGN); | |||
There was a problem hiding this comment.
This is handled process wide from hyperiond
m-seker
force-pushed
the
refactor/qt_connections
branch
from
ec8d07b to
c709915
Compare
|
Here is your new link to your workflow artifacts. |
m-seker
force-pushed
the
refactor/qt_connections
branch
from
c709915 to
6d164b7
Compare
|
Here is your new link to your workflow artifacts. |
Lord-Grey
approved these changes
Jul 27, 2020
Lord-Grey
pushed a commit
to Lord-Grey/hyperion.ng
that referenced
this pull request
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Get rid of old style Qt connections.
Some minor fixes.
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: