Fix OSX build

[m-seker]

Summary

As the title says.

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Build-related changes
• Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

• Yes
• No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

• When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature
• Related documents have been updated (docs/docs/en)
• Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

• Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

[hyperion-project]

Hello @m-seker 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

[m-seker]

This matches apple too (x86_64)

[tpmodding]

➜  build git:(master) cmake -DPLATFORM=osx -DCMAKE_BUILD_TYPE=Debug ..  
-- CMake Version: 3.18.1
CMake Deprecation Warning at CMakeLists.txt:18 (CMAKE_POLICY):
  The OLD behavior for policy CMP0026 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.


-- PLATFORM: osx
-- ENABLE_AMLOGIC = OFF
-- ENABLE_DISPMANX = OFF
-- ENABLE_FB = OFF
-- ENABLE_OSX = OFF
-- ENABLE_SPIDEV   = OFF
-- ENABLE_TINKERFORGE = OFF
-- ENABLE_V4L2 = OFF
-- ENABLE_WS281XPWM = OFF
-- ENABLE_AVAHI = ON
-- ENABLE_USB_HID = OFF
-- ENABLE_CEC = OFF
-- ENABLE_X11 = ON
-- ENABLE_XCB = ON
-- ENABLE_QT = ON
-- ENABLE_TESTS = OFF
-- ENABLE_PROFILER = OFF
-- ENABLE_EXPERIMENTAL = OFF
-- validate json file
-- Current Version: 2.0.0-alpha.7
--  - Build: master (GitHub-4b44e7a0/4099d12d-1596898283)
-- GNU gold linker is not available, falling back to default system linker
-- Found Qt Version: 5.15.0
-- Found libusb-1.0:
--  - Includes: /usr/local/include/libusb-1.0
--  - Libraries: /usr/local/lib/libusb-1.0.dylib
-- Looking for strtof_l
-- Looking for strtof_l - not found
-- Looking for strtoull_l
-- Looking for strtoull_l - not found
Proceeding with version: 1.12.0.103
-- Using flatbuffers compiler: /Users/Serhan/Downloads/hyperion/osx_build/build/bin/flatc
-- Found ZLIB: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/lib/libz.tbd (found version "1.2.11") 
-- Looking for dlfcn.h
-- Looking for dlfcn.h - found
-- Looking for inttypes.h
-- Looking for inttypes.h - found
-- Looking for memory.h
-- Looking for memory.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stdlib.h
-- Looking for stdlib.h - found
-- Looking for strings.h
-- Looking for strings.h - found
-- Looking for string.h
-- Looking for string.h - found
-- Looking for sys/stat.h
-- Looking for sys/stat.h - found
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for unistd.h
-- Looking for unistd.h - found
-- Protobuf: doing try-compiles for hash map/set headers
-- Protobuf: doing try-compiles for pthread test
-- Looking for stddef.h
-- Looking for stddef.h - found
CMake Deprecation Warning at dependencies/external/protobuf/src/CMakeLists.txt:329 (cmake_policy):
  The OLD behavior for policy CMP0026 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.


-- Using protobuf compiler: /Users/Serhan/Downloads/hyperion/osx_build/build/bin/protoc
-- Found Python3: /usr/local/Frameworks/Python.framework/Versions/3.8/bin/python3.8 (found version "3.8.5") found components: Interpreter 
-- Using static mbedtls libraries (build version "2.23.0")
-- Found Python3: /usr/local/Frameworks/Python.framework/Versions/3.8/bin/python3.8 (found version "3.8.5") found components: Interpreter Development Development.Module Development.Embed 
CMake Error at /usr/local/Cellar/cmake/3.18.1/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find X11 (missing: X11_X11_INCLUDE_PATH X11_X11_LIB)
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.18.1/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/Cellar/cmake/3.18.1/share/cmake/Modules/FindX11.cmake:407 (find_package_handle_standard_args)
  libsrc/grabber/x11/CMakeLists.txt:6 (find_package)


-- Configuring incomplete, errors occurred!
See also "/Users/Serhan/Downloads/hyperion/osx_build/build/CMakeFiles/CMakeOutput.log".
See also "/Users/Serhan/Downloads/hyperion/osx_build/build/CMakeFiles/CMakeError.log".

why is this option off? :D -- ENABLE_OSX = OFF

[m-seker]

Looks like something like this is missing :

if (APPLE OR "${PLATFORM}" MATCHES "osx")
    set(ENABLE_OSX ON)
endif()

But your error happens because of something else ?

[tpmodding]

hyperion.ng/CMakeLists.txt

Line 115 in 4099d12

SET ( DEFAULT_OSX ON )

this line should trigger it on...or?
but yep, the failure is here
Could NOT find X11 (missing: X11_X11_INCLUDE_PATH X11_X11_LIB)

but github can build it without errors, and the packages from github works...

[m-seker]

You are right, interesting.