ENABLE_AVAHI is not included in WebServer #996
Conversation
|
Hello @m-seker 👋 I'm your friendly neighborhood bot and would like to say thank you for So that you and other users can test your changes more quickly, If you make changes to your PR, i create a new link to your workflow artifacts. Best regards, |
|
Here is your new link to your workflow artifacts. |
| { | ||
| Info(_log,"Started on port %d", _port); | ||
| #ifdef ENABLE_AVAHI | ||
| if(_serviceRegister == nullptr) |
There was a problem hiding this comment.
@Paulchen-Panther This is documented but not implemented. I am not missing anything right ?
There was a problem hiding this comment.
@brindosch made the last change to the AVAHI interface. Maybe you should check his PR to see if he has deactivated something that is missing now.
#738
I can't say much without looking deeper because @brindosch introduced the AVAHI interface. Sorry
There was a problem hiding this comment.
Avahi support seems to be implemented before that PR and I don't see FlatBuffer advertisement there as well. Probably forgotten.
Thanks.
|
@m-seker Ready? |
Summary
Fixes #995
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: