Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests should not be provided to user if stream has been reset #30

Open
carllerche opened this issue Aug 24, 2017 · 3 comments
Open

Comments

@carllerche
Copy link
Collaborator

carllerche commented Aug 24, 2017

For example, the server receives a request, then an invalid sequence of window updates. The stream is then reset. In this case, the server app should never see the request.

@carllerche carllerche added this to the v0.1 milestone Sep 18, 2017
@seanmonstar
Copy link
Member

Should this actually be done at this level? You could imagine a request with useful info sent, but the client doesn't want the response at all, and so sends a cancel after the headers. In this case, the app never knows what data was sent.

Even if the stream was reset for another reason, the app may still want to be able to log that.

@carllerche
Copy link
Collaborator Author

Maybe... it seems OK to punt this question until later. It is not a breaking change either way I would say.

@carllerche carllerche removed this from the v0.1 milestone Nov 29, 2017
@nox
Copy link
Contributor

nox commented May 6, 2021

This issue is kinda at odds with #536. I feel like the user of the h2 crate should see as much as possible of the data that was send to it, as long as it isn't at odds with respecting the semantics of the protocol.

Should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants