-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream stacking occurs when H2 processes HTTP2 RST_STREAM frames. #621
Comments
Requests can be provided to users after REST. However, num_reset_streams must be reduced after the request is processed to ensure that max_reset_streams takes effect. |
@seanmonstar please check this MR |
@silence-coding this should be closed too now that #668 is merged. |
Ah yes, thanks for remembering! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@seanmonstar As described in the issue in hyper, I think the size of the slab should be limited to max_concurrent_streams + max_concurrent_reset_streams . When the size of the slab exceeds the upper limit, the recv_frame method should discard the received Headers and PushPromise frames and send the protocol error to the client.
hyperium/hyper#2877
Drop the Headers and PushPromise frames here and throw a GoAway error.
h2/src/proto/connection.rs
Line 460 in e4cf88c
The text was updated successfully, but these errors were encountered: