Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream stacking occurs when H2 processes HTTP2 RST_STREAM frames. #621

Closed
silence-coding opened this issue Jun 8, 2022 · 4 comments
Closed

Comments

@silence-coding
Copy link
Contributor

silence-coding commented Jun 8, 2022

@seanmonstar As described in the issue in hyper, I think the size of the slab should be limited to max_concurrent_streams + max_concurrent_reset_streams . When the size of the slab exceeds the upper limit, the recv_frame method should discard the received Headers and PushPromise frames and send the protocol error to the client.
hyperium/hyper#2877

Drop the Headers and PushPromise frames here and throw a GoAway error.

fn recv_frame(&mut self, frame: Option<Frame>) -> Result<ReceivedFrame, Error> {

@silence-coding
Copy link
Contributor Author

Requests can be provided to users after REST. However, num_reset_streams must be reduced after the request is processed to ensure that max_reset_streams takes effect.
#30

@lidong14
Copy link

@seanmonstar please check this MR

@kevinji
Copy link

kevinji commented Apr 13, 2023

@silence-coding this should be closed too now that #668 is merged.

@seanmonstar
Copy link
Member

Ah yes, thanks for remembering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants