Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_send_buffer_size documentation states default is 400 MB. It is 400 KB. #718

Closed
Protryon opened this issue Oct 16, 2023 · 2 comments · Fixed by #719
Closed

max_send_buffer_size documentation states default is 400 MB. It is 400 KB. #718

Protryon opened this issue Oct 16, 2023 · 2 comments · Fixed by #719

Comments

@Protryon
Copy link
Contributor

The documentation for max_send_buffer_size state the default is 400 MB. It appears to be 400 KB from looking at the code. We we're pretty alarmed by this at first.
@seanmonstar
Copy link
Member

Oh, good catch! Where was the mistake, in hyper or in h2? Want to submit a PR?

@Protryon
Copy link
Contributor Author

It was in h2 documentation. Yeah I'll submit one later today I suppose.

Protryon added a commit to Protryon/h2 that referenced this issue Oct 18, 2023
@Protryon
Fix documentation for max_send_buffer_size (hyperium#718)
78383f0
@Protryon Protryon mentioned this issue Oct 18, 2023
Merged
seanmonstar pushed a commit that referenced this issue Oct 19, 2023
@Protryon @seanmonstar
Fix documentation for max_send_buffer_size (#718)
4aa7b16
0xE282B0 pushed a commit to 0xE282B0/h2 that referenced this issue Jan 11, 2024
@Protryon @0xE282B0
Fix documentation for max_send_buffer_size (hyperium#718)
fdf2b25
0xE282B0 pushed a commit to 0xE282B0/h2 that referenced this issue Jan 11, 2024
@Protryon @0xE282B0
Fix documentation for max_send_buffer_size (hyperium#718)
43aa830
0xE282B0 pushed a commit to 0xE282B0/h2 that referenced this issue Jan 16, 2024
@Protryon @0xE282B0
Fix documentation for max_send_buffer_size (hyperium#718)
e9d2798 
Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix documentation for max_send_buffer_size (#718) Protryon/h2
2 participants
@seanmonstar @Protryon