Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov #59

Closed
wants to merge 6 commits into from
Closed

Fix codecov #59

wants to merge 6 commits into from

Conversation

carllerche
Copy link
Collaborator

No description provided.

@@ -29,12 +34,6 @@ script:
# Generate docs
- cargo doc --no-deps

after_success:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my bad, sorry.

@hawkw
Copy link
Collaborator

hawkw commented Sep 7, 2017

Looked into this by running travis-cargo coverage on my machine locally, and it looks like travis-cargo may be no longer passing the correct flags to kcov?

@hawkw
Copy link
Collaborator

hawkw commented Sep 7, 2017

@carllerche I think my PR #61 will actually fix coverage report uploading from CI, sorry this was such a struggle!

If we want GitHub commit status for coverage reports, someone who's a repo owner will have to set up that integration.

@carllerche
Copy link
Collaborator Author

I'll close this in favor of #62

@carllerche carllerche closed this Sep 8, 2017
@hawkw
Copy link
Collaborator

hawkw commented Sep 10, 2017

FWIW we're not the only ones having issues w/ travis-cargo: huonw/travis-cargo#72
unfortunately, it looks pretty unmaintained.

@carllerche carllerche deleted the codecov branch September 18, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants