Remove PollExt trait #625
Merged
Remove PollExt trait #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! It looks like the MSRV job is failing (I've fixed that on master), care to rebase? When did the methods stabilize? We try to keep the MSRV at least 6 months old, and prefer to only upgrade when there's a decent improvement. |
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
kckeiks
force-pushed
the
remove-pollext-trait
branch
from
4e583d1
to
b059583
Compare
|
@seanmonstar They were stabilized on January of 2021 (rust-lang/rust#80968). |
Abhinandan-Purkait
pushed a commit
to openebs/h2
that referenced
this pull request
May 8, 2024
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
Abhinandan-Purkait
pushed a commit
to openebs/h2
that referenced
this pull request
May 8, 2024
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
Abhinandan-Purkait
pushed a commit
to openebs/h2
that referenced
this pull request
May 8, 2024
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
Abhinandan-Purkait
pushed a commit
to openebs/h2
that referenced
this pull request
May 9, 2024
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Rust #63512 was stabilized so this PR removes the
PollExttrait.