improve ci/h2spec.sh (macOS compat, /tmp dir and overwrite) #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- detect if run on MacOS, so we download h2spec macos build in that case - support overwriting h2spec detection so we anyway download new file, useful in case you switch to new version for example - move h2spec, archive and log all to /tmp dir as to not polute the repo dir
|
We just haven't remembered to keep up to date. What are the failures? |
I mentioned it here, but either way I do think it deserves a separate PR. Diff: diff --git a/ci/h2spec.sh b/ci/h2spec.sh
index 9b3e14b..4cb08bd 100755
--- a/ci/h2spec.sh
+++ b/ci/h2spec.sh
@@ -14,10 +14,10 @@ done
if ! [ -e "/tmp/h2spec" ] || $override_h2spec ; then
# if we don't already have a h2spec executable, wget it from github
if [[ "$OSTYPE" == "darwin"* ]]; then
- curl -L -o /tmp/h2spec_darwin_amd64.tar.gz https://github.com/summerwind/h2spec/releases/download/v2.1.1/h2spec_darwin_amd64.tar.gz \
+ curl -L -o /tmp/h2spec_darwin_amd64.tar.gz https://github.com/summerwind/h2spec/releases/download/v2.6.0/h2spec_darwin_amd64.tar.gz \
&& tar xf /tmp/h2spec_darwin_amd64.tar.gz -C /tmp
else
- curl -L -o /tmp/h2spec_linux_amd64.tar.gz https://github.com/summerwind/h2spec/releases/download/v2.1.1/h2spec_linux_amd64.tar.gz \
+ curl -L -o /tmp/h2spec_linux_amd64.tar.gz https://github.com/summerwind/h2spec/releases/download/v2.6.0/h2spec_linux_amd64.tar.gz \
&& tar xf /tmp/h2spec_linux_amd64.tar.gz -C /tmp
fi
fiCmd + Output:
|
|
Sure, separate PR fixing those and upgrading would be great! I don't think they're concerning, it looks like differences on error conditions. Would you want to investigate and try to fix? |
seanmonstar
approved these changes
Nov 4, 2024
Sure thing, added it to my whiteboard backlog, for a little snack this week. Will follow up. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note one or more follow up tasks might be required because this is also using an out of date h2spec archive. We are already a handful of major versions further. I tried to switch it over but there were a lot of failures. Is that because of:
h2spech2-serverexampleh2crate?Some guidance is appreciated here and if you have me I could help contribute some or all fixes for this? At the very least this hopefully gets the ball rolling on this as I do have intuitively the feeling that we might want to stay up to date with a tool we use, especially when it tests for h2spec compatibility / correctness?
This is however separate from this patch as this are just some improvements that allow it to be run on my dev machine as well as in CI, it should not affect the existing usage by (linux) users.