Skip to content

Access-Control-Request-Headers should not use a space when combining #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sebsebmc opened this issue Apr 9, 2025 · 1 comment
Open

Access-Control-Request-Headers should not use a space when combining #207

sebsebmc opened this issue Apr 9, 2025 · 1 comment
Labels
easy

Comments

@sebsebmc
Copy link

sebsebmc commented Apr 9, 2025 •
edited
Loading

The Fetch CORS spec specifically notes that the header list that is the value of ACRH does not use combine and only uses , (comma) to join the header names.

MDN's example value for this header also does not use spaces.

The WPT test https://github.com/web-platform-tests/wpt/blob/master/xhr/resources/access-control-preflight-request-header-sorted.py tests for this strictly.
@seanmonstar
Copy link
Member

Well that's unfortunate (as the spec even says).

@sebsebmc sebsebmc changed the title Access-Control-Allow-Headers should not use a space when combining Access-Control-Request-Headers should not use a space when combining Apr 10, 2025
This was referenced Apr 10, 2025
Open
Merged
github-merge-queue bot pushed a commit to servo/servo that referenced this issue Apr 11, 2025
@sebsebmc
Manually concatenate ACRH headers to not include a space (#36455)
f9035cf 
headers library will join values with `, ` (comma space) but
Access-Control-Request-Headers specifies that it does not use the normal
combining algorithm and values should be joined with `,` (comma).

Testing: WPT tests exist
Fixes: temporary fix for #36451 until hyperium/headers#207 is fixed

Signed-off-by: Sebastian C <sebsebmc@gmail.com>
github-merge-queue bot pushed a commit to servo/servo that referenced this issue Apr 11, 2025
@sebsebmc
Manually concatenate ACRH headers to not include a space (#36455)
1c97077 
headers library will join values with `, ` (comma space) but
Access-Control-Request-Headers specifies that it does not use the normal
combining algorithm and values should be joined with `,` (comma).

Testing: WPT tests exist
Fixes: temporary fix for #36451 until hyperium/headers#207 is fixed

Signed-off-by: Sebastian C <sebsebmc@gmail.com>
github-merge-queue bot pushed a commit to servo/servo that referenced this issue Apr 11, 2025
@sebsebmc
Manually concatenate ACRH headers to not include a space (#36455)
8adf866 
headers library will join values with `, ` (comma space) but
Access-Control-Request-Headers specifies that it does not use the normal
combining algorithm and values should be joined with `,` (comma).

Testing: WPT tests exist
Fixes: temporary fix for #36451 until hyperium/headers#207 is fixed

Signed-off-by: Sebastian C <sebsebmc@gmail.com>
github-merge-queue bot pushed a commit to servo/servo that referenced this issue Apr 11, 2025
@sebsebmc
Manually concatenate ACRH headers to not include a space (#36455)
87c40b4 
headers library will join values with `, ` (comma space) but
Access-Control-Request-Headers specifies that it does not use the normal
combining algorithm and values should be joined with `,` (comma).

Testing: WPT tests exist
Fixes: temporary fix for #36451 until hyperium/headers#207 is fixed

---------

Signed-off-by: Sebastian C <sebsebmc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmonstar @sebsebmc