Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix capacity overflows in HeaderMap::reserve #360

Merged
merged 1 commit into from
Nov 26, 2019
Merged

fix capacity overflows in HeaderMap::reserve #360

merged 1 commit into from
Nov 26, 2019

Conversation

seanmonstar
Copy link
Member

Fixes #352

hawkw
hawkw approved these changes Nov 26, 2019
View reviewed changes
src/header/map.rs Show resolved Hide resolved
@seanmonstar seanmonstar merged commit 81ceb61 into master Nov 26, 2019
@seanmonstar seanmonstar deleted the header-map-reserve-overflow branch November 26, 2019 00:30
@jstarry jstarry mentioned this pull request Jan 9, 2020
Merged
roy-work added a commit to roy-work/advisory-db that referenced this pull request Jan 9, 2020
@roy-work
Correct affected version range on RUSTSEC-2019-003[34] to patched at …
200651c 
…0.1.20

I believe these two vulnerabilities were patched at 0.1.20.

For RUSTSEC-2019-0033:

The advisory links to the bug: hyperium/http#352
In that bug, the fixing PR was hyperium/http#360
That PR merged the commit 81ceb61 to fix the bug; that commit, according to
GitHub, was first picked up by tag v0.1.20 ([commit][1]).

[1]: hyperium/http@81ceb61

For RUSTSEC-2019-0034:

This advisory is two separate GitHub issues against `HeaderMap::drain`,
http rustsec#354 and http rustsec#355.

For the first: the issue: hyperium/http#354
In that bug, the fixing PR was hyperium/http#357
That PR merged the commit 82d53db to fix the bug; that commit, according to
GitHub, was first picked up by tag v0.1.20 ([commit][2]).

[2]: hyperium/http@82d53db

For the second: the issue: hyperium/http#355
In that bug, the fixing PR was hyperium/http#362
That PR merged the commit 8ffe094 to fix the bug; that commit, according to
GitHub, was first picked up by tag v0.1.20 ([commit][3]).

[3]: hyperium/http@8ffe094
@roy-work roy-work mentioned this pull request Jan 9, 2020
Merged
@jstarry jstarry mentioned this pull request Jan 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Size issue in HeaderMap::reserve()
2 participants
@seanmonstar @hawkw