Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable simpler header name parser in debug builds #521

Closed
wants to merge 4 commits into from
Closed

Enable simpler header name parser in debug builds #521

wants to merge 4 commits into from

Conversation

ibraheemdev
Copy link

This shaves close to a second off debug builds on my machine.

@hawkw
Copy link
Contributor

hawkw commented Jan 25, 2022

If we're going to do this, it seems like it might also be a good idea to add a CI step to run the tests in release mode? Otherwsie, most of the parser code is no longer tested on CI.

@seanmonstar
Copy link
Member

Maybe I'm misunderstanding... Seems this is turning off the debug assertions?

@ibraheemdev
Copy link
Author

It makes it so the simpler version of parse_hdr in any debug builds, instead of only in WASM debug builds. debug_assertions is the cfg flag that identifies a debug build (ish).

@seanmonstar
Copy link
Member

I'd normally think in a debug build we'd want the extra checks.

@jeddenlea
Copy link
Contributor

#499 removes the eq macro in all cases.

@ibraheemdev
Copy link
Author

Closing in favor of #499.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants