Fix insufficient validation of the Uri authority component can lead to a panic when calling host() afterwards.
#613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing, but the issue seems unrelated. @seanmonstar can you verify please? |
|
Oh, yea, seems like a dev-dependency is past our MSRV. I've filed #614 to only run |
|
Ok, fixed that, if you want to rebase, it should be better here. |
added 2 commits
June 12, 2023 17:02
… correct order. This avoids panic when attempting to parse odd strings like `]o[`. Signed-off-by: Michael Rodler <mrodler@amazon.de> Reviewed-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Michael Rodler <mrodler@amazon.de>
seanmonstar
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the presence of both square brackets was checked, but not the order. This made
]o[validate as a good uri authority. However, calling theAuthority::hostfunction then panics.I also added a check for too many
:chars in the authority.