Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use non-zero ports resolved by dns resolvers #148

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat: use non-zero ports resolved by dns resolvers #148

merged 2 commits into from
Sep 17, 2024

Conversation

Nuhvi
Copy link
Contributor

@Nuhvi Nuhvi commented Sep 14, 2024

Partly solves seanmonstar/reqwest#2413

@Nuhvi
Copy link
Contributor Author

Nuhvi commented Sep 16, 2024

Not sure how can I fix this CI failiure.

@seanmonstar
Copy link
Member

I've fixed it in #149.

@Nuhvi Nuhvi force-pushed the feat/accept-non-zero-ports branch from 6637563 to e7c9193 Compare September 16, 2024 18:26
@Nuhvi Nuhvi requested a review from seanmonstar September 17, 2024 16:59
seanmonstar
seanmonstar approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the tests, this is excellent <3

@seanmonstar seanmonstar merged commit 2639193 into hyperium:master Sep 17, 2024
16 checks passed
@Nuhvi Nuhvi mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuhvi @seanmonstar