Fix todo!() errors in legacy client #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the todo!() with relevant errors from hyper::Error
seanmonstar
approved these changes
May 22, 2023
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
Hey, thanks for fixing these up! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
todo!()with relevant errors fromhyper::Error.I saw istio/ztunnel#525 mention some not implemented errors in the legacy.rs client. I'm just an observer of both projects but figured I could make an attempt to clean up some of these
todo!()s with something relevant from the hyper 0.14 side of things.Feel free to close if this is way off, but this seems like a simple fix as folks are smoothing out the API.
cc @howardjohn