-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
A-bodyArea: body streaming.Area: body streaming.A-http2Area: HTTP/2 specific.Area: HTTP/2 specific.C-featureCategory: feature. This is adding a new feature.Category: feature. This is adding a new feature.E-easyEffort: easy. A task that would be a great starting point for a new contributor.Effort: easy. A task that would be a great starting point for a new contributor.
Description
Currently sending bodies will just push unbounded into the h2 buffer. While this works, unbounded buffering is not so great. Instead, hyper should check for existing window capacity before polling the body for data.
Steps to fix
- Basically, update
proto::h2::PipeToSendStream
similar to how it was done in this commit.
Metadata
Metadata
Assignees
Labels
A-bodyArea: body streaming.Area: body streaming.A-http2Area: HTTP/2 specific.Area: HTTP/2 specific.C-featureCategory: feature. This is adding a new feature.Category: feature. This is adding a new feature.E-easyEffort: easy. A task that would be a great starting point for a new contributor.Effort: easy. A task that would be a great starting point for a new contributor.