Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyper should skip automatic Content-Length header for HTTP 304 responses #1797

Closed
KamilaBorowska opened this issue Apr 15, 2019 · 1 comment · Fixed by #1801
Closed

Hyper should skip automatic Content-Length header for HTTP 304 responses #1797

KamilaBorowska opened this issue Apr 15, 2019 · 1 comment · Fixed by #1801
Labels
A-http1 Area: HTTP/1 specific. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@KamilaBorowska
Copy link

KamilaBorowska commented Apr 15, 2019 •
edited
Loading

It's unnecessary, see RFC 7232.

Currently Hyper for empty bodies with Content-Length header unset automatically sets the value 0 which is incorrect for HTTP 304 responses, the correct values are either to not provide Content-Length (recommended by specification) or to provide Content-Length of a full response.
@KamilaBorowska KamilaBorowska mentioned this issue Apr 15, 2019
Merged
@seanmonstar seanmonstar added A-http1 Area: HTTP/1 specific. C-feature Category: feature. This is adding a new feature. labels Apr 22, 2019
@seanmonstar
Copy link
Member

This gets set here:

hyper/src/proto/h1/role.rs

Line 479 in 8d70bac

extend(dst, b"content-length: 0\r\n");

A check could be added there for cases when there should be no header added.

@seanmonstar seanmonstar added the E-easy Effort: easy. A task that would be a great starting point for a new contributor. label Apr 22, 2019
@jxs jxs mentioned this issue Apr 25, 2019
Merged
seanmonstar pushed a commit that referenced this issue May 7, 2019
@jxs @seanmonstar
fix(server): skip automatic Content-Length header for HTTP 304 responses
b342c38 
Closes #1797
@psmit psmit mentioned this issue Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-http1 Area: HTTP/1 specific. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(server): skip automatic Content-Length header for HTTP 304 responses jxs/hyper
2 participants
@seanmonstar @KamilaBorowska